Skip to content

fix: ask for language and browser install #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skn0tt merged 2 commits into from
Oct 8, 2025
Merged

fix: ask for language and browser install #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
745dd34
fix: ask for language and browser install
Skn0tt Oct 7, 2025
c62126c
Update src/cli.ts
Skn0tt Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ program
.name('create-playwright')
.description('Getting started with writing end-to-end tests with Playwright.')
.argument('[rootDir]', 'Target directory for the Playwright project', '.')
.option('--browser <browser...>', 'browsers to use in default config', ['chromium', 'firefox', 'webkit'])
.option('--browser <browser...>', `browsers to use in default config (default: 'chromium,firefox,webkit')`)
.option('--no-browsers', 'do not download browsers (can be done manually via \'npx playwright install\')')
.option('--no-examples', 'do not create example test files')
.option('--install-deps', 'install dependencies')
Expand All @@ -33,7 +33,7 @@ program
.option('--ct', 'install Playwright Component testing')
.option('--quiet', 'do not ask for interactive input prompts')
.option('--gha', 'install GitHub Actions')
.option('--lang <language>', 'language to use (js, TypeScript)', 'TypeScript')
Copy link
Member

@yury-s yury-s Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually wanted to drop js 😄

Copy link
Member Author

@Skn0tt Skn0tt Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, then let's remove all the code that goes with it!

Copy link
Member

@yury-s yury-s Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was inadvertent change, but I am for removing the code related to js.

.option('--lang <language>', 'language to use (js, TypeScript)')
.action(async (rootDir, options) => {

const cliOptions: CliOptions = {
Expand Down
4 changes: 2 additions & 2 deletions src/generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ export type PromptOptions = {
const assetsDir = path.join(__dirname, '..', 'assets');

export type CliOptions = {
lang: string;
browser: string[];
lang?: string;
browser?: string[];
noBrowsers?: boolean;
noExamples?: boolean;
installDeps?: boolean;
Expand Down