chore: apply single version policy on web-components domain #33660
+26
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
Hotell
added
web-components
dependencies
Hotell
commented
Jan 15, 2025
Collaborator
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
fabricteam
reviewed
Jan 15, 2025
change/@fluentui-chart-web-components-5f931ecf-3d29-492f-814a-a717ff2375d9.json
Show resolved
Hide resolved
📊 Bundle size report✅ No changes found |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Jan 15, 2025
change/@fluentui-chart-web-components-5f931ecf-3d29-492f-814a-a717ff2375d9.json
Show resolved
Hide resolved
|
Pull request demo site: URL |
AtishayMsft
approved these changes
Jan 15, 2025
mainframev
approved these changes
Jan 15, 2025
Contributor
Author
|
can we get review on this one @chrisdholt @radium-v ? ty |
radium-v
reviewed
Apr 15, 2025
Contributor
radium-v
left a comment
radium-v
left a comment
There was a problem hiding this comment.
There's another version-locked dependency entry for @microsoft/fast-element present in apps/vr-tests-web-components/package.json. Can that be removed as well?
| "@microsoft/api-extractor": "7.39.0", | ||
| "@microsoft/api-extractor-model": "7.28.3", | ||
| "@microsoft/eslint-plugin-sdl": "0.1.9", | ||
| "@microsoft/fast-element": "2.0.0", |
Contributor
Author
There was a problem hiding this comment.
Im not the right person to do this decision. this PR doesn't upgrade rather moves to SVP following the existing set of specified deps per package. feel free to update as you need ofc
Hotell
force-pushed
the
chore/web-components-svp
branch
from
cf6ff0a to
18d2828
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png | 6 | Changed |
| vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png | 5 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 12 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 849 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 659 | Changed |
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 678 | Changed |
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 444 | Changed |
vr-tests-web-components/MenuList 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - RTL.normal.chromium_1.png | 39082 | Changed |
vr-tests-web-components/RadioGroup 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/RadioGroup. - Dark Mode.normal.chromium_1.png | 59 | Changed |
vr-tests-web-components/Switch 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Switch. - Dark Mode.hover.chromium_2.png | 92 | Changed |
vr-tests/Callout 10 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.Beak 25.default.chromium.png | 2185 | Changed |
| vr-tests/Callout.Bottom center.default.chromium.png | 2116 | Changed |
| vr-tests/Callout.Bottom left edge - RTL.default.chromium.png | 2186 | Changed |
| vr-tests/Callout.Bottom right edge.default.chromium.png | 1120 | Changed |
| vr-tests/Callout.Left bottom edge.default.chromium.png | 3123 | Changed |
| vr-tests/Callout.Bottom right edge - RTL.default.chromium.png | 1114 | Changed |
| vr-tests/Callout.No callout width specified.default.chromium.png | 2126 | Changed |
| vr-tests/Callout.Right top edge.default.chromium.png | 1116 | Changed |
| vr-tests/Callout.Root.default.chromium.png | 2181 | Changed |
| vr-tests/Callout.Top right edge.default.chromium.png | 1134 | Changed |
vr-tests/Keytip 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Keytip.Offset.default.chromium.png | 86 | Changed |
| vr-tests/Keytip.Root.default.chromium.png | 51 | Changed |
vr-tests/react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png | 11 | Changed |
vr-tests/react-charting-LineChart 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-LineChart.Events.default.chromium.png | 1 | Changed |
| vr-tests/react-charting-LineChart.Multiple - Dark Mode.default.chromium.png | 181 | Changed |
| vr-tests/react-charting-LineChart.Multiple - RTL.default.chromium.png | 200 | Changed |
| vr-tests/react-charting-LineChart.Multiple.default.chromium.png | 192 | Changed |
vr-tests/react-charting-VerticalBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png | 3 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
Contributor
Author
that's an application, apps should keep their production deps ( ideally aligned with SVP version ). this is standard approach if one would like to dockerize it etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
patchchange type onchart-web-componentsRelated Issue(s)