Skip to content

chore: apply single version policy on web-components domain #33660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hotell wants to merge 4 commits into
base: master
Choose a base branch
from
+26 −16
Open

chore: apply single version policy on web-components domain #33660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
173e16f
chore: apply single version policy on web-components domain
Hotell Jan 15, 2025
0bdc9d9
fix(chart-wc): dissalow patch change type
Hotell Jan 15, 2025
18d2828
change files
Hotell Jan 15, 2025
dcc2dd0
fixup! chore: apply single version policy on web-components domain
Hotell May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-chart-web-components-5f931ecf-3d29-492f-814a-a717ff2375d9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link

@github-actions github-actions bot May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png 6 Changed
vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png 5 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 12 Changed
vr-tests-react-components/Positioning.Positioning end.chromium.png 849 Changed
vr-tests-react-components/TagPicker 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png 659 Changed
vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png 678 Changed
vr-tests-web-components/Badge 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png 444 Changed
vr-tests-web-components/MenuList 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/MenuList. - RTL.normal.chromium_1.png 39082 Changed
vr-tests-web-components/RadioGroup 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/RadioGroup. - Dark Mode.normal.chromium_1.png 59 Changed
vr-tests-web-components/Switch 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-web-components/Switch. - Dark Mode.hover.chromium_2.png 92 Changed
vr-tests/Callout 10 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Callout.Beak 25.default.chromium.png 2185 Changed
vr-tests/Callout.Bottom center.default.chromium.png 2116 Changed
vr-tests/Callout.Bottom left edge - RTL.default.chromium.png 2186 Changed
vr-tests/Callout.Bottom right edge.default.chromium.png 1120 Changed
vr-tests/Callout.Left bottom edge.default.chromium.png 3123 Changed
vr-tests/Callout.Bottom right edge - RTL.default.chromium.png 1114 Changed
vr-tests/Callout.No callout width specified.default.chromium.png 2126 Changed
vr-tests/Callout.Right top edge.default.chromium.png 1116 Changed
vr-tests/Callout.Root.default.chromium.png 2181 Changed
vr-tests/Callout.Top right edge.default.chromium.png 1134 Changed
vr-tests/Keytip 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/Keytip.Offset.default.chromium.png 86 Changed
vr-tests/Keytip.Root.default.chromium.png 51 Changed
vr-tests/react-charting-AreaChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png 11 Changed
vr-tests/react-charting-LineChart 4 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-LineChart.Events.default.chromium.png 1 Changed
vr-tests/react-charting-LineChart.Multiple - Dark Mode.default.chromium.png 181 Changed
vr-tests/react-charting-LineChart.Multiple - RTL.default.chromium.png 200 Changed
vr-tests/react-charting-LineChart.Multiple.default.chromium.png 192 Changed
vr-tests/react-charting-VerticalBarChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png 3 Changed

There were 2 duplicate changes discarded. Check the build logs for more information.

"type": "none",
"comment": "chore: disallow patch change type",
"packageName": "@fluentui/chart-web-components",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@fluentui-web-components-1aa38841-fbc5-4873-963d-623765c6f691.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "chore: adopt single version policy for dev deps",
"packageName": "@fluentui/web-components",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
"@microsoft/api-extractor": "7.49.1",
"@microsoft/api-extractor-model": "7.30.2",
"@microsoft/eslint-plugin-sdl": "1.0.1",
"@microsoft/fast-element": "2.0.0",
Copy link
Contributor

@radium-v radium-v Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be ^2.2.0?

Copy link
Contributor Author

@Hotell Hotell May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not the right person to do this decision. this PR doesn't upgrade rather moves to SVP following the existing set of specified deps per package. feel free to update as you need ofc

"@microsoft/load-themed-styles": "1.10.26",
"@microsoft/loader-load-themed-styles": "2.0.17",
"@microsoft/tsdoc": "0.15.1",
Expand Down Expand Up @@ -100,6 +101,8 @@
"@storybook/components": "7.6.20",
"@storybook/core-events": "7.6.20",
"@storybook/core-server": "7.6.20",
"@storybook/html": "7.6.20",
"@storybook/html-webpack5": "7.6.20",
"@storybook/manager-api": "7.6.20",
"@storybook/preview-api": "7.6.20",
"@storybook/react": "7.6.20",
Expand All @@ -109,6 +112,7 @@
"@swc/core": "1.5.7",
"@swc/helpers": "0.5.1",
"@swc/jest": "0.2.36",
"@tensile-perf/web-components": "0.2.0",
"@testing-library/dom": "8.11.3",
"@testing-library/jest-dom": "5.16.5",
"@testing-library/react": "12.1.2",
Expand Down Expand Up @@ -190,6 +194,7 @@
"beachball": "2.31.0",
"chalk": "4.1.0",
"chrome-remote-interface": "0.28.2",
"chromedriver": "125.0.3",
"ci-info": "3.8.0",
"circular-dependency-plugin": "5.2.2",
"clean-css": "4.2.3",
Expand Down
10 changes: 3 additions & 7 deletions packages/charts/chart-web-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,7 @@
"test:dev": "playwright test"
},
"devDependencies": {
"@microsoft/fast-element": "2.0.0",
"@fluentui/scripts-api-extractor": "*",
"@tensile-perf/web-components": "~0.2.0",
"@storybook/html": "7.6.20",
"@storybook/html-webpack5": "7.6.20",
"chromedriver": "^125.0.0"
"@fluentui/scripts-api-extractor": "*"
},
"dependencies": {
"@microsoft/fast-web-utilities": "^6.0.0",
Expand All @@ -113,7 +108,8 @@
"beachball": {
"disallowedChangeTypes": [
"major",
"minor"
"minor",
"patch"
],
"tag": "alpha"
}
Expand Down
9 changes: 2 additions & 7 deletions packages/web-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,17 +102,12 @@
"e2e:local": "node ./scripts/e2e.js --ui"
},
"devDependencies": {
"@custom-elements-manifest/analyzer": "0.10.4",
"@fluentui/scripts-api-extractor": "*",
"@microsoft/fast-element": "2.0.0",
"@tensile-perf/web-components": "~0.2.0",
"@storybook/html": "7.6.20",
"@storybook/html-webpack5": "7.6.20",
"@wc-toolkit/cem-validator": "1.0.3",
"@wc-toolkit/cem-inheritance": "1.0.4",
"@wc-toolkit/module-path-resolver": "1.0.0",
"@wc-toolkit/type-parser": "1.0.3",
"chromedriver": "^125.0.0"
"@custom-elements-manifest/analyzer": "0.10.4",
"@fluentui/scripts-api-extractor": "*"
},
"dependencies": {
"@microsoft/fast-web-utilities": "^6.0.0",
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4678,7 +4678,7 @@
dependencies:
"@tensile-perf/tools" "0.1.7"

"@tensile-perf/web-components@~0.2.0":
"@tensile-perf/web-components@0.2.0":
version "0.2.0"
resolved "https://registry.yarnpkg.com/@tensile-perf/web-components/-/web-components-0.2.0.tgz#355ac463a121656e68c0567f9c15accf19b61734"
integrity sha512-NEKH6d/2HrOJgW60E/oZ/O2D4vjzBv9xgSQmAz1cQnrEyQ/Odz/l3OWDwfEobcg8VHm6iODVoNAyvYAr4ESTKQ==
Expand Down Expand Up @@ -8396,7 +8396,7 @@ chrome-trace-event@^1.0.2:
dependencies:
tslib "^1.9.0"

chromedriver@^125.0.0:
chromedriver@125.0.3:
version "125.0.3"
resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-125.0.3.tgz#4c7cf13e54cd3575b88d4376a53d659cabb0ae05"
integrity sha512-Qzuk5Wian2o3EVGjtbz6V/jv+pT/AV9246HbG6kUljZXXjsKZLZxqJC+kHR3qEh/wdv4EJD0YwAOWV72v9hogw==
Expand Down
Loading