-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(react-utilities): add custom RefAttributes interface which is used within ForwardRefComponent to mitigate React.RefAttributes expansion causing breaking changes in v8/v9 mixed context - shipped as patch release in @types/react@18.2.61
#34572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hotell
merged 6 commits into
microsoft:master
from
Hotell:react-18/introduce-custom-ref-html-and-migrate
Jun 6, 2025
Merged
feat(react-utilities): add custom RefAttributes interface which is used within ForwardRefComponent to mitigate React.RefAttributes expansion causing breaking changes in v8/v9 mixed context - shipped as patch release in @types/react@18.2.61
#34572
Hotell
merged 6 commits into
microsoft:master
from
Hotell:react-18/introduce-custom-ref-html-and-migrate
Jun 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RefAttributes interface which is used within ForwardRefComponent to mitigate breaking changes shipped as patch release in @types/react@18.2.61
Hotell
commented
Jun 2, 2025
RefAttributes interface which is used within ForwardRefComponent to mitigate breaking changes shipped as patch release in @types/react@18.2.61RefAttributes interface which is used within ForwardRefComponent to mitigate breaking changes shipped as patch release in @types/react@18.2.61
dmytrokirpa
approved these changes
Jun 2, 2025
|
Pull request demo site: URL |
📊 Bundle size report✅ No changes found |
change/@fluentui-react-utilities-66a3d122-bdde-45be-a7b3-d6ae2b28a1d6.json
Show resolved
Hide resolved
RefAttributes interface which is used within ForwardRefComponent to mitigate breaking changes shipped as patch release in @types/react@18.2.61RefAttributes interface which is used within ForwardRefComponent to mitigate unexpected React.RefAttributes changes shipped as patch release in @types/react@18.2.61
RefAttributes interface which is used within ForwardRefComponent to mitigate unexpected React.RefAttributes changes shipped as patch release in @types/react@18.2.61RefAttributes interface which is used within ForwardRefComponent to mitigate React.RefAttributes expansion causing breaking changes in v8/v9 mixed context - shipped as patch release in @types/react@18.2.61
df780d9 to
89e436b
Compare
…RefComponent to mitigate breaking changes shipped as patch release in @types/react@18.2.61
89e436b to
813b1fb
Compare
dmytrokirpa
approved these changes
Jun 4, 2025
1 task
bsunderhus
reviewed
Jun 4, 2025
bsunderhus
approved these changes
Jun 6, 2025
… it belongs and add test case
…n where it belongs and add test case
mainframev
pushed a commit
to mainframev/fluentui
that referenced
this pull request
Jun 9, 2025
…used within ForwardRefComponent to mitigate `React.RefAttributes` expansion causing breaking changes in v8/v9 mixed context - shipped as patch release in @types/react@18.2.61 (microsoft#34572)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Introduces a custom
RefAttributestype to address compatibility issues withReact.RefAttributesacross different versions of React (17, 18, and 19).The changes ensure consistent types for
refprops in components and mitigate type issues caused bybreakingunion extension changes in React's type definitions (RefAttributesrefproperty) (see DefinitelyTyped/DefinitelyTyped#68720).Uses the new
RefAttributestype as part ofForwardRefComponentto ship deterministic type no matter what@types/reactversion is usedBefore:
After:
Related Issue(s)