-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore: upgrade storybook to v8 #35279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
packages/react-components/react-avatar/stories/src/Avatar/AvatarDefault.stories.tsx
Show resolved
Hide resolved
c46247f to
74ff328
Compare
packages/react-components/react-storybook-addon/src/docs/FluentCanvas.tsx
Show resolved
Hide resolved
packages/react-components/react-storybook-addon/src/docs/FluentDocsPage.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-storybook-addon/src/docs/FluentStory.tsx
Outdated
Show resolved
Hide resolved
|
haven't reviewed the PR yet. vr tests are broken ( that is expected ) https://github.com/microsoft/fluentui/actions/runs/18388203718/job/52391892405?pr=35279 we need to migrate to new API that we implemented for SB8+ support microsoft/storywright#74, should work also for v7 - should be easy to codemod via agent microsoft/storywright#74 |
6e3a6f7 to
46d3791
Compare
46d3791 to
e8391fc
Compare
e8391fc to
25e3fdd
Compare
Addressed in a separate PR #35346 |
packages/react-components/react-storybook-addon/src/docs/FluentDocsPage.tsx
Outdated
Show resolved
Hide resolved
change/@fluentui-storybook-llms-extractor-1c0802d8-4111-44b5-b6b1-82d9d461888b.json
Outdated
Show resolved
Hide resolved
.../@fluentui-react-storybook-addon-export-to-sandbox-e826cc4e-1629-4a56-b91e-864b8456f4c1.json
Outdated
Show resolved
Hide resolved
change/@fluentui-react-storybook-addon-ee7ab7c2-7aae-4b6f-8e9f-700123d875f7.json
Outdated
Show resolved
Hide resolved
3bea22c to
0b4b5ae
Compare
0b4b5ae to
e864cf3
Compare
Hotell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work ty!
Previous Behavior
Storybook 7 is used in the monorepo
New Behavior
Migrate to storybook v8, migration guide:
FluentCanvasandFluentStorycomponents to keep the same behavior as in SB v7@storybook/iconsetc.*.stories.mdxfiles to*.mdxexport tags = ['autodocs']to every.storybook/preview.jsfileRelated Issue(s)