Skip to content

Conversation

@dmytrokirpa
Copy link
Contributor

@dmytrokirpa dmytrokirpa commented Oct 3, 2025

Previous Behavior

Storybook 7 is used in the monorepo

New Behavior

Migrate to storybook v8, migration guide:

  • update all storybook related deps to v8+
  • add custom FluentCanvas and FluentStory components to keep the same behavior as in SB v7
  • update deprecated apis like @storybook/icons etc.
  • migrate to MDX3, rename *.stories.mdx files to *.mdx
  • added export tags = ['autodocs'] to every .storybook/preview.js file

Related Issue(s)

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

📊 Bundle size report

✅ No changes found

@github-actions
Copy link

github-actions bot commented Oct 5, 2025

Pull request demo site: URL

@dmytrokirpa dmytrokirpa requested review from a team and spmonahan as code owners October 9, 2025 20:59
@Hotell
Copy link
Contributor

Hotell commented Oct 14, 2025

haven't reviewed the PR yet.

vr tests are broken ( that is expected ) https://github.com/microsoft/fluentui/actions/runs/18388203718/job/52391892405?pr=35279

we need to migrate to new API that we implemented for SB8+ support microsoft/storywright#74, should work also for v7 - should be easy to codemod via agent microsoft/storywright#74

@dmytrokirpa
Copy link
Contributor Author

haven't reviewed the PR yet.

vr tests are broken ( that is expected ) https://github.com/microsoft/fluentui/actions/runs/18388203718/job/52391892405?pr=35279

we need to migrate to new API that we implemented for SB8+ support microsoft/storywright#74, should work also for v7 - should be easy to codemod via agent microsoft/storywright#74

Addressed in a separate PR #35346

Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work ty!

@Hotell Hotell merged commit ab76553 into microsoft:master Nov 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants