fix(vr-tests): update test scripts and fix story errors #35496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokirpa
added
Area: Testing
Fluent UI react (v8)
dmytrokirpa
commented
Nov 16, 2025
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
dmytrokirpa
commented
Nov 16, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dmytrokirpa
commented
Nov 18, 2025
dmytrokirpa
commented
Nov 18, 2025
tudorpopams
approved these changes
Nov 18, 2025
This was referenced Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We found in #35346 (comment) that some v8 VR tests were logging errors quietly without causing the pipeline to fail.
New Behavior
--bailOnStoriesErrorflag to thetest-vrscript in package.json for improved error handling.HoverCardstory introduced in dmytrokirpa@4498bc0#diff-d04db666f67aba0b54957a822d2d17e820572bd8cc8bc825f9e5ae9a8c4b0743L29AreaChartstory introduced in dmytrokirpa@4498bc0#diff-3869e0a31f1edb65c61a758ead2c3bc9cecb445be9cd422416b54e7a0e778b16L20Going forward, if there are any errors in the stories, the VR Tests pipelines will fail.
Related Issue(s)
--bailOnStoriesErrorparam tovr-testsandvr-tests-web-components#35430