[http-client-python] refine exception handling logic #5270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadelesh
requested review from
allenjzhang,
bterlson,
iscai-msft,
markcowl,
msyyc and
timotheeguerin
as code owners
Collaborator
|
No changes needing a change description found. |
tadelesh
force-pushed
the
python_exception_handling
branch
from
29e3eca to
82e9b76
Compare
microsoft-github-policy-service
bot
added
emitter:client:python
Collaborator
|
You can try these changes here
|
This was referenced Dec 5, 2024
iscai-msft
approved these changes
Dec 5, 2024
Member
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
this and the resultant generated code diff look good to me, thanks!
Member
Author
|
updated code change: Azure/autorest.python#2953 |
msyyc
approved these changes
Dec 6, 2024
Member
Author
|
tested locally with todoapp. it works good. |
archerzz
pushed a commit
to archerzz/typespec
that referenced
this pull request
Dec 17, 2024
1. add ranged status code support for exception 2. move customized exception handling logic from error map to exception handling 3. add `_failsafe_deserialize` function to provide fail saft deserialization for exception to support always return http response exception fix: Azure/autorest.python#2937 fix: Azure/autorest.python#2940
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
…n groups (#5506) regression from #5270 fix: Azure/autorest.python#2975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_failsafe_deserializefunction to provide fail saft deserialization for exception to support always return http response exceptionfix: Azure/autorest.python#2937
fix: Azure/autorest.python#2940