Skip to content

Conversation

@Y3drk
Copy link
Contributor

@Y3drk Y3drk commented Jan 2, 2026

Lite PR


Summary


Why


Testing

  • Tested the ENSAdmin's UI manually in the local and Vercel preview for:
    • Our alpha ENSNode instances
    • Our sepolia ENSNode instance
    • Our mainnet ENSNode instance

Why is testing not completed?

  • Recently (GitHub indicates 12/23/25) @shrugs made changes regarding the subgraph fallback, including an improved data model and validation schema (see: packages/ensnode-sdk/src/shared/config/thegraph.ts)
  • As far as I know, none of our instances currently host an rc / code that includes these changes, hence when trying to connect to either sepolia or mainnet instances the following error is thrown
image
  • I had a lot of problems with hosting ENSNode by myself in the past, so I'd like to avoid that for such a small UI change. Also, I firmly believe that my fix is sound and expect that once we deploy a version supporting these changes, I will be able to confirm it and complete the testing
  • I want to test this change on different instances of ENSNode to check if the filtering of "activated features" will behave correctly after the fix, ex. the subgraph compatability feature should be displayed as deactivated for alpha instances and as activated for mainnet instances.

Notes for Reviewer (Optional)

  • The most important changes are located in apps/ensadmin/src/components/connection/config-info/config-info.tsx (lines 229-282, 343, and 528-536)
  • Changes in apps/ensadmin/src/components/connection/config-info/app-card.tsx are just a removal of an unused props

Checklist

  • This PR does not change runtime behavior or semantics
  • This PR is low-risk and safe to review quickly

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2026

⚠️ No Changeset found

Latest commit: fe9da10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
admin.ensnode.io Ready Ready Preview, Comment Jan 2, 2026 2:48pm
ensnode.io Ready Ready Preview, Comment Jan 2, 2026 2:48pm
ensrainbow.io Ready Ready Preview, Comment Jan 2, 2026 2:48pm

@Y3drk Y3drk self-assigned this Jan 2, 2026
@Y3drk Y3drk linked an issue Jan 2, 2026 that may be closed by this pull request
@Y3drk
Copy link
Contributor Author

Y3drk commented Jan 2, 2026

Since it's a very minor UI fix, I've decided not to include changesets. Let me know if they should be added 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix "Activated Features" UI on ENSAdmin "Connection" screen

2 participants