PENG-6092: attempt to deal with race condition by returning success on duplication error #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uccess on the already exists error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the orb-agent receives the same policy twice from the gRPC server, so it attempts to delete and reapply: in the pktvisor logs we don't see the delete, successful or not, but the second apply throws an error which causes the orb-agent to classify the policy as failed.
Ideally the orb-agent shouldn't try to reapply the same policy until it can at least confirm it failed, but I don't want to create yet another fork so I want to test if there is a simpler way to deal with the situation: e.g. if the second apply returns a success the orb-agent might start pulling data from it.