specify explicit path for getVersion
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug when using NPM@3. Here it's quite common that both `handy` and `to` are installed into the project's top-level `node_modules` directory. As such `getVersion` would actually access the project's package.json and not that of handy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when using NPM@3. Here it's quite common that both
handyandtoare installed into the project's top-levelnode_modulesdirectory. As suchgetVersionwould actually access the project's package.json and not that of handy.There is another pull request for this but it has a bug itself, since it tries to pass the 'package.json' file to
getVersion(), but the latter actually wants a module path.