[release-4.20] update the endpointslice to filter ports that are on localhost on the containerport #333
Conversation
aabughosh
changed the title
… containerport - filter localhost container ports since they are not externally exposed - unit test thats checking the filter function
aabughosh
force-pushed
the
cherry-pick-325-to-release-4.20
branch
from
6de09dc to
8770da6
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aabughosh, oribon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@aabughosh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.19 |
|
@aabughosh: new pull request created: #358 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.19 |
|
@aabughosh: new pull request created: #360 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cherry pick #325
Cherry-picking directly from the GitHub commit didn’t work because the changes depend on fields introduced in version 4.21 (specifically, the nodeRole was renamed to nodeGroup). In our tests commatrix created nodes reflecting this new change, which don’t exist in 4.20.
Since 4.20 lacks the updated machine configuration, and the test relied on a fake client, I applied the changes manually to make them compatible with 4.20.