Skip to content

[release-4.19] update the endpointslice to filter ports that are on localhost on the containerport #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
openshift-cherrypick-robot wants to merge 1 commit into
base: release-4.19
Choose a base branch
from
Open

[release-4.19] update the endpointslice to filter ports that are on localhost on the containerport #360

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 1, 2026

This is an automated cherry-pick of #333

/assign aabughosh

@aabughosh
update the endpointslice to filter ports that are on localhost on the…
beed695 
… containerport

- filter localhost container ports since they are not externally exposed
- unit test thats checking the filter function
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 1, 2026
Merged
@openshift-ci
Copy link

openshift-ci bot commented Jan 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign sabinaaledort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aabughosh
Copy link
Collaborator

aabughosh commented Jan 1, 2026

/retest

@aabughosh
Copy link
Collaborator

aabughosh commented Jan 1, 2026

its need this pr openshift/cluster-version-operator#1283 to pass

@openshift-ci
Copy link

openshift-ci bot commented Jan 1, 2026

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/commatrix-e2e-tests-1of2 beed695 link true /test commatrix-e2e-tests-1of2
ci/prow/commatrix-e2e-tests-2of2 beed695 link true /test commatrix-e2e-tests-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabinaaledort sabinaaledort Awaiting requested review from sabinaaledort

@shirmoran shirmoran Awaiting requested review from shirmoran

Assignees

@aabughosh aabughosh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@openshift-cherrypick-robot @aabughosh