master, v8.5: update download URL from pingcap.org to pingcap.com #22240
Conversation
Oreoxmt
added
translation/from-docs-cn
Summary of ChangesHello @Oreoxmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a critical maintenance task: updating all references to download URLs within the documentation. The change ensures that users are directed to the correct and current domain for downloading TiDB components, tools, and related packages, thereby preventing broken links and improving the user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ti-chi-bot
bot
added
the
size/M
Oreoxmt
changed the title
Oreoxmt
added
the
needs-cherry-pick-release-8.5
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request primarily updates download URLs across multiple documentation files, changing the domain from download.pingcap.org to download.pingcap.com. Additionally, a review comment points out an issue in dm/quick-start-create-task.md where a wget command downloads a version-specific file, but the subsequent tar command expects a different, generic filename, suggesting a fix to use wget -O to ensure the downloaded file is saved with the expected name for extraction.
|
|
||
| ```bash | ||
| wget https://download.pingcap.org/tidb-community-server-v8.5.0-linux-amd64.tar.gz | ||
| wget https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz |
There was a problem hiding this comment.
The wget command downloads a file with a version-specific name (tidb-community-server-v8.5.0-linux-amd64.tar.gz), but the subsequent tar command tries to extract a file named tidb-latest-linux-amd64.tar.gz. This will cause the script to fail. To fix this, you can use the -O flag with wget to save the downloaded file with the expected name.
| wget https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz | |
| wget -O tidb-latest-linux-amd64.tar.gz https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz |
|
/lgtm |
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
3 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?