master, v8.5: update download URL from pingcap.org to pingcap.com (#22240) #22280
Conversation
ti-chi-bot
added
do-not-merge/hold
|
@Oreoxmt This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates all download links within the TiDB documentation, transitioning them from the 'pingcap.org' domain to the new 'pingcap.com' domain. This change ensures that users are consistently directed to the correct and up-to-date resources for downloading TiDB server, toolkit, and monitoring-related packages. Additionally, some dynamic version placeholders in example URLs have been replaced with a hardcoded 'v8.5.0' for clarity in specific documentation sections. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates download URLs from pingcap.org to pingcap.com. While most changes are correct, several files contain unresolved merge conflicts that were likely introduced during the automated cherry-pick process. These conflicts must be resolved to prevent rendering issues in the documentation. I have provided suggestions to fix these critical issues. Additionally, I've included a correction for a minor inconsistency in one of the files.
dm/quick-start-create-task.md
Outdated
| <<<<<<< HEAD | ||
| wget https://download.pingcap.org/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz | ||
| ======= | ||
| wget https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz | ||
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) |
There was a problem hiding this comment.
This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>). This will cause rendering issues in the documentation and must be resolved.
| <<<<<<< HEAD | |
| wget https://download.pingcap.org/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz | |
| ======= | |
| wget https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz | |
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) | |
| wget https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz |
download-ecosystem-tools.md
Outdated
| <<<<<<< HEAD | ||
| `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | ||
| ======= | ||
| `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v8.5.0-linux-amd64.tar.gz`. | ||
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) |
There was a problem hiding this comment.
This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>). This will cause rendering issues in the documentation and must be resolved.
| <<<<<<< HEAD | |
| `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | |
| ======= | |
| `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v8.5.0-linux-amd64.tar.gz`. | |
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) | |
| `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v8.5.0-linux-amd64.tar.gz`. |
pd-control.md
Outdated
| <<<<<<< HEAD | ||
| > `{version}` in the link indicates the version number of TiDB. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | ||
| ======= | ||
| > `{version}` in the link indicates the version number of TiDB. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz`. | ||
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) |
There was a problem hiding this comment.
This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>). This will cause rendering issues in the documentation and must be resolved.
| <<<<<<< HEAD | |
| > `{version}` in the link indicates the version number of TiDB. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-server-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | |
| ======= | |
| > `{version}` in the link indicates the version number of TiDB. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz`. | |
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) | |
| > `{version}` in the link indicates the version number of TiDB. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz`. |
production-deployment-using-tiup.md
Outdated
| <<<<<<< HEAD | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | ||
| ======= | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v8.5.0-linux-amd64.tar.gz`. | ||
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) |
There was a problem hiding this comment.
This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>). This will cause rendering issues in the documentation and must be resolved.
| <<<<<<< HEAD | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | |
| ======= | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v8.5.0-linux-amd64.tar.gz`. | |
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v8.5.0-linux-amd64.tar.gz`. |
upgrade-monitoring-services.md
Outdated
| <<<<<<< HEAD | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | ||
| ======= | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-{{{ .tidb-version }}}-linux-amd64.tar.gz`. | ||
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) |
There was a problem hiding this comment.
This block contains unresolved merge conflict markers, which will break the documentation rendering. Please resolve the conflict.
Additionally, there's a minor inconsistency: the instruction in step 1 is to download the tidb-community-server package, but the example URL in this tip points to the tidb-community-toolkit package. I've updated the example to point to the server package to match the instruction.
| <<<<<<< HEAD | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | |
| ======= | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-{{{ .tidb-version }}}-linux-amd64.tar.gz`. | |
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz`. |
upgrade-monitoring-services.md
Outdated
| <<<<<<< HEAD | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | ||
| ======= | ||
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v8.5.0-linux-amd64.tar.gz`. | ||
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) |
There was a problem hiding this comment.
This block also contains unresolved merge conflict markers. Please resolve the conflict.
Similar to the Prometheus section, the instruction here is to download the tidb-community-server package, but the example URL points to the tidb-community-toolkit package. I've updated the example to point to the server package for consistency.
| <<<<<<< HEAD | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v{{{ .tidb-version }}}` in the `amd64` architecture is `https://download.pingcap.org/tidb-community-toolkit-v{{{ .tidb-version }}}-linux-amd64.tar.gz`. | |
| ======= | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-toolkit-v8.5.0-linux-amd64.tar.gz`. | |
| >>>>>>> f9d0913543 (master, v8.5: update download URL from pingcap.org to pingcap.com (#22240)) | |
| > `{version}` in the link indicates the version number of TiDB and `{arch}` indicates the architecture of the system, which can be `amd64` or `arm64`. For example, the download link for `v8.5.0` in the `amd64` architecture is `https://download.pingcap.com/tidb-community-server-v8.5.0-linux-amd64.tar.gz`. |
Oreoxmt
force-pushed
the
cherry-pick-22240-to-release-8.5
branch
from
5844094 to
0017d1e
Compare
|
/approve |
|
/unhols |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
This is an automated cherry-pick of #22240
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?