Alerts #538

MateoLostanlen · 2025-12-23T11:10:03Z

This PR introduces an alerts feature on the API side, including the data model, schemas, CRUD layer, and endpoints. It also integrates alerts into the existing detections and sequences flows.

What changed

Alerts API

New alerts endpoint
- src/app/api/api_v1/endpoints/alerts.py
New alert domain layer
- CRUD: src/app/crud/crud_alert.py
- Schemas: src/app/schemas/alerts.py
- Model updates in src/app/models.py
Router and dependency wiring updated accordingly

Sequences and detections

Updates to sequences.py and detections.py
Cone computation performed at sequence creation time
Field naming aligned (started_at, last_seen_at)
Alert related hooks integrated into the sequence lifecycle

Overlap logic

Overlap computation is included via src/app/services/overlap.py
This logic originates from PR Triangulation inside API #516 and has been moved here to avoid duplication
PR Triangulation inside API #516 will be closed in favor of this PR, which contains the consolidated implementation

Scope clarification, intentional follow up

A new detection splitting strategy based on bbox and pose_id is planned
This change is intentionally not included in this PR to keep the scope manageable
The bbox plus pose_id based split will be introduced in a separate follow up PR

How to test

Using the dev environment

You can use the dedicated dev environment
https://github.com/pyronear/pyro-envdev
Start the stack as documented in the repository

Notebook example

Once the environment is running, open the following notebook for a concrete example of alert generation and triangulation
http://0.0.0.0:8889/notebooks/notebooks/send_real_alerts.ipynb

socket-security · 2025-12-23T11:10:29Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	License
numpy@1.26.4
numpy@2.4.0
pandas@2.3.3
networkx@3.6
networkx@3.6.1
botocore@1.42.13 ⏵ 1.42.14	^-2	^-30
nodeenv@1.9.1 ⏵ 1.10.0	⁺¹
pyproj@3.7.2
boto3@1.42.13 ⏵ 1.42.14	^-1	^-19
geopy@2.4.1
geographiclib@2.1

View full report

codecov · 2025-12-23T11:12:49Z

Codecov Report

❌ Patch coverage is 76.56613% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.51%. Comparing base (ac3e175) to head (662300e).

Files with missing lines	Patch %	Lines
src/app/api/api_v1/endpoints/sequences.py	41.81%	32 Missing ⚠️
src/app/services/overlap.py	84.61%	24 Missing ⚠️
src/app/api/api_v1/endpoints/detections.py	75.34%	18 Missing ⚠️
src/app/api/api_v1/endpoints/alerts.py	79.31%	12 Missing ⚠️
src/app/api/api_v1/endpoints/organizations.py	41.66%	7 Missing ⚠️
src/app/db.py	33.33%	6 Missing ⚠️
src/app/crud/base.py	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   83.99%   82.51%   -1.48%     
==========================================
  Files          42       47       +5     
  Lines        1318     1687     +369     
==========================================
+ Hits         1107     1392     +285     
- Misses        211      295      +84

Flag	Coverage Δ
backend	`82.44% <76.56%> (-1.58%)`	⬇️
client	`83.67% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fe51

Hi there, thanks a lot for the PR.

I have started to review it, here are few comments and questions before going deeper.

fe51 · 2025-12-30T14:33:58Z

src/app/models.py

    pose_id: Union[int, None] = Field(None, foreign_key="poses.id", nullable=True)
    azimuth: float = Field(..., ge=0, lt=360)
    is_wildfire: Union[AnnotationType, None] = None
+    cone_azimuth: Union[float, None] = Field(None, nullable=True)


Here cone_azimuth is what is expected to be the azimuth of the sequence right ? Does sequence_azimuth sounds good to you ? We must find something as clear as possible to avoid consfusion

fe51 · 2025-12-30T14:37:55Z

src/app/models.py

    azimuth: float = Field(..., ge=0, lt=360)
    is_wildfire: Union[AnnotationType, None] = None
+    cone_azimuth: Union[float, None] = Field(None, nullable=True)
+    cone_angle: Union[float, None] = Field(None, nullable=True)


Should not we go for angular_width? Also, this one must be in degree, hence a suggestion below

Suggested change

cone_angle: Union[float, None] = Field(None, nullable=True)

angular_width: Union[float, None] = Field(None, ge=0, lt=360, nullable=True)

(modification must be done elsewhere to adapt the naming)

src/app/models.py

fe51 · 2025-12-30T14:45:06Z

src/app/db.py


 async def get_session() -> AsyncSession:  # type: ignore[misc]
-    async_session = sessionmaker(bind=engine, class_=AsyncSession, expire_on_commit=False)
+    async_session = async_sessionmaker(bind=engine, class_=AsyncSession, expire_on_commit=False)


Naive question: why do we need to switch to asynchronous approach here?

src/app/services/overlap.py

fe51 · 2025-12-30T15:19:40Z

src/app/schemas/alerts.py

+
+
+class AlertUpdate(BaseModel):
+    organization_id: Optional[int] = Field(None, gt=0)


As AlertCreate and Alertupdate have properties in common, you might create a AlertBase schemas to put shared properties (org id, lat lon, started_at, last_seen_at might be deferent if optinnal in one case but not the other)

fe51 · 2025-12-30T15:35:48Z

src/app/models.py

+class Alert(SQLModel, table=True):
+    __tablename__ = "alerts"
+    id: int = Field(None, primary_key=True)
+    organization_id: int = Field(..., foreign_key="organizations.id", nullable=False)


Suggested change

organization_id: int = Field(..., foreign_key="organizations.id", nullable=False)

Why organization_id is needed here ? Shouldn't we handle it like we do for sequences, and cross-check via the user's scope?

We need it to filter alerts, when you fetch alerts using fetch_latest_unlabeled_alerts for exemple you want alerts from your organisation only

fe51 · 2025-12-30T15:38:49Z

src/app/api/api_v1/endpoints/organizations.py

    telemetry_client.capture(
        token_payload.sub, event="organizations-deletion", properties={"organization_id": organization_id}
    )
+    # Remove alerts and their associations for this organization to satisfy FK constraints


As mentioned in the model comments -> if the organisationid is not required in alerts, this part of the code must therefore be deleted.

same as previous comment

fe51 · 2025-12-30T15:39:49Z

src/app/schemas/alerts.py

+
+
+class AlertCreate(BaseModel):
+    organization_id: int = Field(..., gt=0)


org_id might not be needed in alert db model, hence not useful in schema

fe51 · 2025-12-30T17:12:54Z

src/app/api/api_v1/endpoints/detections.py

+    )
+
+    # Ensure the newly created sequence is present
+    if all(seq.id != sequence_.id for seq in recent_sequences):


Naive question, in which case the sequence could be missing ?

when you create a new sequence

fe51 · 2025-12-30T17:16:48Z

src/app/api/api_v1/endpoints/detections.py

+            "lat": float(cam.lat),
+            "lon": float(cam.lon),
+            "cone_azimuth": float(seq.cone_azimuth),
+            "cone_angle": float(seq.cone_angle),


(maybe to) Rename according to what is chosen as the attribute name in the database model.

MateoLostanlen added 18 commits December 22, 2025 08:33

compute cone during seq creation

b0387f0

round values

05c2930

drop seq with cones

212bac9

create alerts

2be61dd

add overlap from triangulation pr

d504b35

new alerts strat

c508900

missing init

756038b

missings deps

f6cf578

use preset variable

086cd7d

updates routes

b9e3faf

update poetry

2d8d6d0

update loc

45e5cbb

error management

f8523c4

fix on seq case

4fe12f8

use started_at and last_seens_at

1bb2d20

clean output

2527baa

missing READ

31a3960

add test

e5ab687

github-actions bot added topic: build Related to build, installation & CI endpoint: detections module: services ext: tests module: schemas module: models endpoint: sequences labels Dec 23, 2025

MateoLostanlen added 3 commits December 23, 2025 12:24

fix style

92510a8

test overlap

0140d29

mypy

f1a4236

MateoLostanlen added 2 commits December 23, 2025 12:33

ruff on test overlap

cf8a8ed

import issue

0bc7de1

github-actions bot added module: core module: database module: crud labels Dec 23, 2025

fix style

6ab2d8d

MateoLostanlen force-pushed the alerts branch from 3e18740 to 6ab2d8d Compare December 23, 2025 12:15

fix deletions to respect fk

83626e0

github-actions bot added the endpoint: organizations label Dec 23, 2025

cast

19e5762

MateoLostanlen requested review from fe51 and frgfm and removed request for fe51 December 23, 2025 14:54

MateoLostanlen added 3 commits December 23, 2025 16:03

recompyte alerts after seq annotation

2bc5efb

fix alert update

56ad18b

style

761fefd

MateoLostanlen force-pushed the alerts branch from 5d59011 to 761fefd Compare December 23, 2025 16:21

MateoLostanlen added 5 commits December 23, 2025 17:22

style

a306c0b

adapt test

2ab57fd

ruff on test

afda94e

add tests on detections

1d9732f

increase test on seq

204bbb6

MateoLostanlen force-pushed the alerts branch from 4c944fc to 204bbb6 Compare December 24, 2025 08:27

ruff

662300e

MateoLostanlen mentioned this pull request Dec 29, 2025

Split detections #539

Draft

fe51 reviewed Dec 30, 2025

View reviewed changes

	cone_angle: Union[float, None] = Field(None, nullable=True)
	angular_width: Union[float, None] = Field(None, ge=0, lt=360, nullable=True)



		class AlertUpdate(BaseModel):
		organization_id: Optional[int] = Field(None, gt=0)



		class AlertCreate(BaseModel):
		organization_id: int = Field(..., gt=0)

Uh oh!

Alerts #538

Are you sure you want to change the base?

Alerts #538

Uh oh!

Conversation

MateoLostanlen commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Alerts API

Sequences and detections

Overlap logic

Scope clarification, intentional follow up

How to test

Using the dev environment

Notebook example

Uh oh!

socket-security bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fe51 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MateoLostanlen commented Dec 23, 2025 •

edited

Loading

socket-security bot commented Dec 23, 2025 •

edited

Loading

codecov bot commented Dec 23, 2025 •

edited

Loading