Replace logError() with Session.getLog() in SessionConnector
#1108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SessionConnectorwas logging errors to its class-level logger instead of using session-specific logs where aSessionobject was available.Changes
logError()calls withLogUtil.logThrowable(session.getLog(), ...)in:logoutAllSessions(): logout errorslogoutAllSessions(): disconnect errorsSessionTimerTask.run(): timer processing errorslogError(SessionID, IoSession, String, Throwable)methodgetLogSuffix(SessionID, IoSession)which was only used bylogError()Before:
After:
This routes errors to per-session log configuration rather than the generic connector logger, consistent with error logging patterns in
Sessionitself. The cleanup removes dead code that is no longer needed.Original prompt
logError()with call toSession.getLog()where applicable inSessionConnector#1107✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.