Skip to content

Conversation

@kndehaan
Copy link
Contributor

Description

This PR adds queries for the biomass sankey for all liquid biofuels.

This PR should be reviewed together with the ETModel branch biomass-sankey.

Type of change

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

Related Issues

Closes #

Copy link
Contributor

@kaskranenburgQ kaskranenburgQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking very good!
One question:
I see that we don't show the flows from biogenic waste to biofuels, for instance the biogenic waste used to create biomethanol via biomethanol synthesis.
Biogenic waste is a carrier that now exists in 'column 0' for the electricity and heat production.

For the gaseous carriers we do show the flow from biogas to greengas.

It feels to me that the biogas flows should be modeled similarly as the biogenic waste flows. Is this intentional?

@kndehaan
Copy link
Contributor Author

Good point! I forgot to include the biogenic waste flow to biofuels. It indeed should be included.

This means that the following flows still need to be added, from biogenic waste to:

  • biokerosene (Fischer-Tropsch)
  • biodiesel (Fischer-Tropsch)
  • bionaphtha (Fischer-Tropsch)
  • biomethanol (methanol synthesis)
  • bio pyrolysis oil (pyrolysis)

I will process this!

@kndehaan
Copy link
Contributor Author

I added the biogenic waste to biofuels flows.

One remark: pyrolysis bio-oil and biomethanol in the second biofuels column have flows going to other biofuels in the second column (e.g. biokerosene, bionaphtha). I didn't see any other way to avoid this, since accounting for these flows implicitly is not really possible I think.

image

A consideration is to place biomethanol and pyrolysis bio-oil in a separate column, before the 'secondary' biofuels. I'm not sure what this would do for the layout, for example readability of the labels. @kaskranenburgQ what do you think?

@kaskranenburgQ
Copy link
Contributor

Nice work! looking good.
I would propose to leave the columns as is. I feel that adding another column would clutter the sankey even more. Curious to hear what @mabijkerk thinks as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants