-
Notifications
You must be signed in to change notification settings - Fork 9
Biomass sankey - liquid biofuels #3395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: biomass-sankey
Are you sure you want to change the base?
Conversation
kaskranenburgQ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking very good!
One question:
I see that we don't show the flows from biogenic waste to biofuels, for instance the biogenic waste used to create biomethanol via biomethanol synthesis.
Biogenic waste is a carrier that now exists in 'column 0' for the electricity and heat production.
For the gaseous carriers we do show the flow from biogas to greengas.
It feels to me that the biogas flows should be modeled similarly as the biogenic waste flows. Is this intentional?
|
Good point! I forgot to include the biogenic waste flow to biofuels. It indeed should be included. This means that the following flows still need to be added, from biogenic waste to:
I will process this! |
|
I added the biogenic waste to biofuels flows. One remark: pyrolysis bio-oil and biomethanol in the second biofuels column have flows going to other biofuels in the second column (e.g. biokerosene, bionaphtha). I didn't see any other way to avoid this, since accounting for these flows implicitly is not really possible I think.
A consideration is to place biomethanol and pyrolysis bio-oil in a separate column, before the 'secondary' biofuels. I'm not sure what this would do for the layout, for example readability of the labels. @kaskranenburgQ what do you think? |
|
Nice work! looking good. |

Description
This PR adds queries for the biomass sankey for all liquid biofuels.
This PR should be reviewed together with the ETModel branch biomass-sankey.
Type of change
Checklist
Related Issues
Closes #