Fix MAX_ADVERT_DATA_SIZE and MAX_PACKET_PAYLOAD #34
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAX_PACKET_PAYLOAD must be 184, see (https://github.com/meshcore-dev/MeshCore/blob/main/docs/packet_structure.md).
MAX_ADVERT_DATA_SIZE must be 32. Even though the protocol isn't clear (https://github.com/meshcore-dev/MeshCore/blob/main/docs/payloads.md), Meshcore imposes a limit of 32 bytes (https://github.com/meshcore-dev/MeshCore/blob/main/src/MeshCore.h).
This fixes pyMC_core sending adverts longer than 32 bytes which get dropped by other repeaters or the Companion App.
With the current limits, the following situations will lead to an advert showing up in the RX log of the companion app, but silently dropped:
The same happens with Letsmesh.