Skip to content

Fix MAX_ADVERT_DATA_SIZE and MAX_PACKET_PAYLOAD #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nikotine1 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix MAX_ADVERT_DATA_SIZE and MAX_PACKET_PAYLOAD #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33d8a31
Fix MAX_ADVERT_DATA_SIZE and MAX_PACKET_PAYLOAD constants to align wi…
Jan 14, 2026
5963512
Remove double declaration of MAX_PACKET_PAYLOAD
Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/pymc_core/protocol/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,15 @@
# ---------------------------------------------------------------------------
# Misc sizes
# ---------------------------------------------------------------------------
MAX_ADVERT_DATA_SIZE = 96
MAX_ADVERT_DATA_SIZE = 32
PUB_KEY_SIZE = 32
SIGNATURE_SIZE = 64
PATH_HASH_SIZE = 1
CIPHER_MAC_SIZE = 32 # SHA‑256 HMAC
CIPHER_BLOCK_SIZE = 16
MAX_PACKET_PAYLOAD = 256 # firmware's default
MAX_PACKET_PAYLOAD = 184 # firmware's default

MAX_PATH_SIZE = 64
MAX_PACKET_PAYLOAD = 256
MAX_HASH_SIZE = 32 # SHA-256 truncated

NAME_MAX_LEN = 16 # Max length of a contact name
Expand Down