Forward-paginate issues and PRs #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like it ought to be identical, but in 1.94.0 I'm seeing PR 151164 (and maybe others, but that's the one picked up as missing despite having a tracking issue) only existing in the forward pagination. It also seems more intuitive to scan forwards in general, so feels reasonable to switch given it fixes the bug without too much more digging. This also adds an assertion that we did fetch all the results which would have made it clearer where the problem was without as much investigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like it ought to be identical, but in 1.94.0 I'm seeing PR 151164 (and maybe others, but that's the one picked up as missing despite having a tracking issue) only existing in the forward pagination. It also seems more intuitive to scan forwards in general, so feels reasonable to switch given it fixes the bug without too much more digging.
This also adds an assertion that we did fetch all the results which would have made it clearer where the problem was without as much investigation.