Skip to content

Forward-paginate issues and PRs #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mark-Simulacrum merged 1 commit into from
Jan 25, 2026
Merged

Forward-paginate issues and PRs #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ fn get_issues_by_milestone_inner(
if ty == "pullRequests" {
args.insert("states", String::from("[MERGED]"));
}
args.insert("last", String::from("100"));
args.insert("first", String::from("100"));
let mut issues = Vec::new();

loop {
Expand All @@ -209,14 +209,15 @@ fn get_issues_by_milestone_inner(
url
body
state
labels(last: 100) {{
labels(first: 100) {{
nodes {{
name
}}
}}
}}
totalCount
pageInfo {{
startCursor
endCursor
}}
}}
}}
Expand Down Expand Up @@ -248,6 +249,7 @@ fn get_issues_by_milestone_inner(
.unwrap();
let status = response.status();
let json = response.json::<json::Value>().unwrap();

if !status.is_success() {
panic!("API Error {}: {}", status, json);
}
Expand All @@ -264,11 +266,16 @@ fn get_issues_by_milestone_inner(
let mut pull_requests = pull_requests_data["nodes"].as_array().unwrap().clone();
issues.append(&mut pull_requests);

match &pull_requests_data["pageInfo"]["startCursor"] {
match &pull_requests_data["pageInfo"]["endCursor"] {
json::Value::String(cursor) => {
args.insert("before", format!("\"{}\"", cursor));
args.insert("after", format!("\"{}\"", cursor));
}
json::Value::Null => {
// Confirm we gathered all the PRs
assert_eq!(
pull_requests_data["totalCount"].as_u64().unwrap(),
issues.len() as u64
);
break issues;
}
_ => unreachable!(),
Expand Down Expand Up @@ -313,6 +320,18 @@ impl TrackingIssues {
let title = o["title"].as_str().unwrap();
if let Some(tail) = title.strip_prefix(PREFIX) {
let for_number = tail[..tail.find(':').unwrap()].parse::<u64>().unwrap();

if !all
.iter()
.any(|i| i["number"].as_u64().unwrap() == for_number)
{
eprintln!(
"Issue #{} is supposed to have relnotes for #{for_number}, \
but #{for_number} is not found in all issues collected",
o["number"]
);
}

let mut sections = HashMap::new();
let body = o["body"].as_str().unwrap();

Expand Down Expand Up @@ -394,6 +413,8 @@ fn map_to_line_items<'a>(
issue.raw["url"].as_str().unwrap(),
));
}
} else {
eprintln!("#{number} has unknown section {:?}", section);
}
}

Expand Down