Skip to content

Try to reduce rustdoc GUI tests flakyness #151692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 27, 2026
Merged

Try to reduce rustdoc GUI tests flakyness #151692

rust-bors merged 1 commit into from
Jan 27, 2026

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jan 26, 2026

Should help with #93784.

I replaced a use of puppeteer.wait function with a loop instead (like the rest of browser-ui-test).

r? @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jan 26, 2026
jieyouxu
jieyouxu approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a shot, thanks

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Jan 27, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

📌 Commit 21ebd03 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2026
@jieyouxu jieyouxu mentioned this pull request Jan 27, 2026
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 27, 2026
@Zalathar
Rollup merge of rust-lang#151692 - GuillaumeGomez:reduce-flaky, r=jie…
de8d203 
…youxu

Try to reduce rustdoc GUI tests flakyness

Should help with rust-lang#93784.

I replaced a use of `puppeteer.wait` function with a loop instead (like the rest of `browser-ui-test`).

r? @jieyouxu
@Zalathar Zalathar mentioned this pull request Jan 27, 2026
Closed
@Zalathar
Copy link
Member

Zalathar commented Jan 27, 2026

Scheduling: If the rollup fails legitimately, fall back to this PR.

@bors p=4

rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151722 - Zalathar:rollup-0Ec7izb, r=Zalathar
2003080 
Rollup of 4 pull requests

Successful merges:

 - #147436 (slice/ascii: Optimize `eq_ignore_ascii_case` with auto-vectorization)
 - #151390 (Reintroduce `QueryStackFrame` split.)
 - #151534 (target: fix destabilising target-spec-json)
 - #151692 (Try to reduce rustdoc GUI tests flakyness)
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026 •
edited
Loading

⌛ Testing commit 21ebd03 with merge f3ada21...

Workflow: https://github.com/rust-lang/rust/actions/runs/21386838846

rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151692 - GuillaumeGomez:reduce-flaky, r=jieyouxu
f3ada21 
Try to reduce rustdoc GUI tests flakyness

Should help with #93784.

I replaced a use of `puppeteer.wait` function with a loop instead (like the rest of `browser-ui-test`).

r? @jieyouxu
@Zalathar Zalathar mentioned this pull request Jan 27, 2026
Merged
@Zalathar
Copy link
Member

Zalathar commented Jan 27, 2026

@bors yield (to enclosing rollup)

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

Auto build cancelled. Cancelled workflows:

The next pull request likely to be tested is #151727.

rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
@bors
Auto merge of #151727 - Zalathar:rollup-goIJldt, r=Zalathar
78df2f9 
Rollup of 5 pull requests

Successful merges:

 - #151692 (Try to reduce rustdoc GUI tests flakyness)
 - #147436 (slice/ascii: Optimize `eq_ignore_ascii_case` with auto-vectorization)
 - #151390 (Reintroduce `QueryStackFrame` split.)
 - #151097 (Use an associated type default for `Key::Cache`.)
 - #151702 (Omit standard copyright notice)
@rust-bors rust-bors bot merged commit 8ae4aca into rust-lang:main Jan 27, 2026
11 of 12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 27, 2026
rust-timer added a commit that referenced this pull request Jan 27, 2026
@rust-timer
Unrolled build for #151692
2653e77 
Rollup merge of #151692 - GuillaumeGomez:reduce-flaky, r=jieyouxu

Try to reduce rustdoc GUI tests flakyness

Should help with #93784.

I replaced a use of `puppeteer.wait` function with a loop instead (like the rest of `browser-ui-test`).

r? @jieyouxu
@GuillaumeGomez GuillaumeGomez deleted the reduce-flaky branch January 27, 2026 13:30
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 27, 2026

The rollup still failed with this CI error: #151743

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 27, 2026

So I guess it didn't fix it. :3

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 27, 2026

This one as well
#151704 (comment)
Since it seems to be always the same test, is it reasonable to disable this test for now until we have a proper fix?
How critical is the test?

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 27, 2026

I'd rather not. I have some ideas. The only way to know a flaky is fixed (or not), is sadly to have a lot of potential CI failures).

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 27, 2026

That could also be in PR ci tho, then it's not in the way of other work

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 27, 2026

No: that's the whole issue with flakyness: doesn't happen all
3the tim8e9999999999999999

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 27, 2026

Cat finished the comment in my stead. So I was trying to say: flaky tests don't fail all the time, proof with this PR which got merged although it didn't fix flakyness issue. So to ensure that it actually fixes it, I think we'll need to keep it enabled. Anyway, I have a few ideas I wanna investigate.

@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez @jieyouxu @Zalathar @JonathanBrouwer @rustbot