Skip to content

Implement set_output_kind for Emscripten linker #151704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hoodmane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement set_output_kind for Emscripten linker #151704

hoodmane wants to merge 1 commit into from

Conversation

@hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jan 26, 2026 •
edited
Loading

This makes cdylibs compile to working Emscripten dynamic libraries without passing extra RUSTFLAGS. This was previously approved as #98358 but there were CI failures that I never got around to fixing.

cc @workingjubilee

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 26, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

Sign in to view
@hoodmane
Implement set_output_kind for Emscripten linker
481c68d 
This makes cdylibs compile to working Emscripten dynamic libraries without passing extra
RUSTFLAGS. This was previously approved as PR 98358 but there were CI failures that I
never got around to fixing.
@hoodmane hoodmane force-pushed the emscripten-set-output-kind branch from 357f3a8 to 481c68d Compare January 26, 2026 18:45
@JayanAXHF JayanAXHF added O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL! A-linkers Area: linkers... you gotta love linkers labels Jan 26, 2026
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jan 26, 2026

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    354d02aa29ac   7 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:596da3f22bcbdff2c96fd7126001278022c834c1621c5efa2ad1a7794590636c
deleted: sha256:354d02aa29acf525570c732b6e006ecf138de6d63ca525d552eb4b24880ddc6c
deleted: sha256:8b7af0e426bc2cbeeacfd96b8354d3b80016991520977197e62090e47abaede8
deleted: sha256:cadf11ef1de7fdd5eab563757942353684047f09b212dc99d6ed48e8acf34d62
deleted: sha256:569b0caf9d5285db44ccd2629a3470139eea755be423a33a54d8a24cb3926bfa
deleted: sha256:f9dc5feb048d8f9fd43137e3998f59e9acfbd76c47a4e14984d109654119e282
---
tests/ui/drop_non_drop.rs ... ok
tests/ui/drain_collect.fixed ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/else_if_without_else.rs ... ok
tests/ui/eager_transmute.rs ... ok
tests/ui/elidable_lifetime_names.rs ... ok
tests/ui/empty_docs.rs ... ok
---
[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

======== tests/rustdoc-gui/setting-go-to-only-result.goml ========

[ERROR] setting-go-to-only-result output:
Execution context was destroyed, most likely because of a navigation.
stack: Error: Execution context was destroyed, most likely because of a navigation.
    at rewriteError (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/ExecutionContext.js:457:15)
    at async #evaluate (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/ExecutionContext.js:389:60)
    at async ExecutionContext.evaluate (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/ExecutionContext.js:277:16)
    at async IsolatedWorld.evaluate (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/IsolatedWorld.js:100:16)
    at async CdpFrame.evaluate (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Frame.js:362:20)
    at async CdpPage.evaluate (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Page.js:826:20)
    at async /checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:432:28
    at async waitForConditionTrue (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/utils.js:209:13)
    at async runAllCommands (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:431:22)
    at async innerRunTestCode (/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/node_modules/browser-ui-test/src/index.js:714:21)



<= doc-ui tests done: 146 succeeded, 1 failed, 0 filtered out

@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 27, 2026
Merged
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 27, 2026

@bors retry

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

❗ You can only retry pull requests that are approved and have a previously failed auto build.

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 27, 2026

Not familiar with this code, rerolling
@rustbot reroll

@rustbot rustbot assigned tiif and unassigned JonathanBrouwer Jan 27, 2026
@hoodmane
Copy link
Contributor Author

hoodmane commented Jan 27, 2026

The same rustdoc-gui/setting-go-to-only-result.goml test is failing on both of my open PRs... @JonathanBrouwer any ideas about that?

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 27, 2026

Yes, this is a spurious issue, you can ignore this. We tried to fix this in #151692 but it didn't work

@hoodmane
Copy link
Contributor Author

hoodmane commented Jan 27, 2026

Is the failure cancelling other CI jobs?

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 27, 2026

This test is spurious and only sometimes succeeds, and got merged into develop

@hoodmane
Copy link
Contributor Author

hoodmane commented Jan 27, 2026

I guess I should just wait a few days until it's fixed on the main branch and then rebase?

@hoodmane
Copy link
Contributor Author

hoodmane commented Jan 27, 2026

Thanks for the help!

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 27, 2026 •
edited
Loading

Yep, I just learned I can also rerun CI jobs if you don't feel like waiting

@hoodmane
Copy link
Contributor Author

hoodmane commented Jan 27, 2026

Won't it just fail again in the same place?

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 27, 2026

It seems to be like a 50/50 chance

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 27, 2026
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2026
@matthiaskrgr
Rollup merge of rust-lang#151759 - GuillaumeGomez:update-browser-ui-t…
5c00c97 
…est, r=GuillaumeGomez

Update `browser-ui-test` version to `0.23.3`

Should fix rust-lang#151704 (comment).
Should help with rust-lang#93784.

r? ghost
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2026
@matthiaskrgr
Rollup merge of rust-lang#151759 - GuillaumeGomez:update-browser-ui-t…
b2a7239 
…est, r=GuillaumeGomez

Update `browser-ui-test` version to `0.23.3`

Should fix rust-lang#151704 (comment).
Should help with rust-lang#93784.

r? ghost
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 27, 2026
@GuillaumeGomez
Rollup merge of rust-lang#151759 - GuillaumeGomez:update-browser-ui-t…
df44104 
…est, r=GuillaumeGomez

Update `browser-ui-test` version to `0.23.3`

Should fix rust-lang#151704 (comment).
Should help with rust-lang#93784.

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tiif tiif

Labels

A-linkers Area: linkers... you gotta love linkers O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL! S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hoodmane @rustbot @rust-log-analyzer @JonathanBrouwer @tiif @JayanAXHF