[FOLLOW UP] Keyboard Input 2.0 #2789
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Artúr Kovács <kovacs.artur.barnabas@gmail.com>
daxpedda
reviewed
May 5, 2023
5 tasks
daxpedda
approved these changes
May 8, 2023
Member
daxpedda
left a comment
daxpedda
left a comment
There was a problem hiding this comment.
Web is LGTM.
When comparing the output of Web and X11, I noticed that using a dead key on X11 gives this:
physical_key: Backquote, logical_key: Unidentified(Xkb(0xFE52))
but on Web it gives this:
physical_key: Backquote, logical_key: Dead(None)
Don't know anything about X11, but maybe Xkb(0xFE52) should be converted to Key::Dead?
5 tasks
2 tasks
This was referenced May 13, 2023
13 tasks
daxpedda
reviewed
May 17, 2023
Member
Author
|
no need in this thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the progress is sort of stalled on #2662 I'm opening this branch to continue the work without messing up with the original branch.
Fixes #1932.
Fixes #1890.
Fixes #1888.