Python 3 support #268
Open
Python 3 support #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronizing shortcuts using src/ice.py works. Not tested with Python 2.7.
Tests now run without deprecation warnings and fail in two cases on Windows because permission work differently. Removing directories containing read-only files also file so the teardown code had to be accommodated.
Owner
|
Hey sorry for letting this sit for so long. I would love to add Python 3 support, but can you confirm that this works with python 2.7 as well? |
Author
|
I found an issue with the CRC code in pysteam, but other than that it worked under Python 2.7. I tried adding and removing a ROM as well and it was fine. I will push a fix for pysteam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified being able to add and remove roms under Python 3, tests also work except for two that fail in Windows because of the way permissions work. Should be compatible with Python 2.7 but needs verification before pulling.