-
-
Notifications
You must be signed in to change notification settings - Fork 5
New Crowdin updates #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
New Crowdin updates #2130
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis PR adds comprehensive localization support by introducing translation files for seven languages (Spanish, French, Indonesian, Korean, Malay, Swahili, Vietnamese) alongside localized platform description files, and updates the English base translations with SortMenu path refactoring and new filter-related UI strings. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
UI unit Tests 1 files 47 suites 18s ⏱️ Results for commit 8da4523. ♻️ This comment has been updated with latest results. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@ms/platform.bible-extension/assets/descriptions/description-ms.md`:
- Line 1: The Malay locale file description-ms.md currently contains English
placeholder text; replace "FieldWorks Lite for Platform.Bible. Powered by
webpack." with a proper Malay translation, ensure the file is saved in UTF-8
without BOM, and update any surrounding metadata if present so the localized
string reads naturally in Malay (e.g., "FieldWorks Lite untuk Platform.Bible.
Dikuasakan oleh webpack." or a more accurate translation as needed).
In `@sw/platform.bible-extension/assets/descriptions/description-sw.md`:
- Line 1: Replace the English placeholder string "FieldWorks Lite for
Platform.Bible. Powered by webpack." in the description-sw.md content with a
proper Swahili translation (e.g., "FieldWorks Lite kwa Platform.Bible.
Inaendeshwa na webpack.") so the Swahili locale is localized; locate the exact
string in the file and update it accordingly, preserving punctuation and file
encoding.
In `@vi/platform.bible-extension/assets/descriptions/description-vi.md`:
- Line 1: The file description-vi.md contains an English placeholder string
"FieldWorks Lite for Platform.Bible. Powered by webpack."—replace this with a
Vietnamese localized description; update the content of description-vi.md to a
user-facing Vietnamese sentence (for example: "FieldWorks Lite cho
Platform.Bible. Vận hành bằng webpack.") or another accurate Vietnamese
translation that conveys the same meaning.
🧹 Nitpick comments (1)
es-ES/platform.bible-extension/assets/descriptions/description-es.md (1)
1-1: Capitalize “Webpack” for brand consistency.Other locales use “Webpack”; matching that improves consistency.
📝 Suggested tweak
-FieldWorks Lite para Platform.Bible. Desarrollado por webpack. +FieldWorks Lite para Platform.Bible. Desarrollado por Webpack.
| @@ -0,0 +1 @@ | |||
| FieldWorks Lite for Platform.Bible. Powered by webpack. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Malay locale file still in English.
This appears to be an untranslated placeholder; should be localized to Malay.
🤖 Prompt for AI Agents
In `@ms/platform.bible-extension/assets/descriptions/description-ms.md` at line 1,
The Malay locale file description-ms.md currently contains English placeholder
text; replace "FieldWorks Lite for Platform.Bible. Powered by webpack." with a
proper Malay translation, ensure the file is saved in UTF-8 without BOM, and
update any surrounding metadata if present so the localized string reads
naturally in Malay (e.g., "FieldWorks Lite untuk Platform.Bible. Dikuasakan oleh
webpack." or a more accurate translation as needed).
| @@ -0,0 +1 @@ | |||
| FieldWorks Lite for Platform.Bible. Powered by webpack. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swahili locale file still in English.
This appears to be an untranslated placeholder; should be localized to Swahili.
🤖 Prompt for AI Agents
In `@sw/platform.bible-extension/assets/descriptions/description-sw.md` at line 1,
Replace the English placeholder string "FieldWorks Lite for Platform.Bible.
Powered by webpack." in the description-sw.md content with a proper Swahili
translation (e.g., "FieldWorks Lite kwa Platform.Bible. Inaendeshwa na
webpack.") so the Swahili locale is localized; locate the exact string in the
file and update it accordingly, preserving punctuation and file encoding.
| @@ -0,0 +1 @@ | |||
| FieldWorks Lite for Platform.Bible. Powered by webpack. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vietnamese locale file still in English.
This looks like an untranslated placeholder; should be localized to Vietnamese for a user-facing description.
🤖 Prompt for AI Agents
In `@vi/platform.bible-extension/assets/descriptions/description-vi.md` at line 1,
The file description-vi.md contains an English placeholder string "FieldWorks
Lite for Platform.Bible. Powered by webpack."—replace this with a Vietnamese
localized description; update the content of description-vi.md to a user-facing
Vietnamese sentence (for example: "FieldWorks Lite cho Platform.Bible. Vận hành
bằng webpack.") or another accurate Vietnamese translation that conveys the same
meaning.
C# Unit Tests146 tests 146 ✅ 19s ⏱️ Results for commit 8da4523. ♻️ This comment has been updated with latest results. |
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
No description provided.