Upgrade to .Net Framework 48 and make SayMore 64-bit #257
Conversation
…ed csproj files to SDK-style
tombogle
added
enhancement
dependencies
…ut still needed on TC)
Stripped out DLLs no longer needed in .Net Framework 4.8 Updated XLIFF files for shared SIL DLLs. Changed the way version numbers are supplied. Restored ICU4c package that got lost during SDK-style conversion Made it possible to ignore signing failures Fixed warning because of per-user keypath registry entry for the SayMore.exe component
…-64-bit # Conflicts: # build/SayMore.proj
andrew-polk
left a comment
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 36 of 36 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @megahirt and @tombogle)
src/SayMoreTests/SayMoreTests.csproj line 44 at r1 (raw file):
<None Remove="Resources\shortSound.wav" /> <None Remove="Resources\shortVideo.wmv" /> <None Remove="Resources\test.eaf" />
Why is this list removed, then included?
|
Previously, andrew-polk wrote…
That pattern is **correct and intentional. It looks weird, but it’s exactly how you’re supposed to override the new defaults. In SDK-style projects, files like these are auto-included as |
andrew-polk
left a comment
andrew-polk
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @megahirt)
andrew-polk
left a comment
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Addresses:
#246
#248
This change is