Skip to content

Migrate Danger to use danger-pr-comment workflow #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dblock merged 1 commit into from
Dec 30, 2025
Merged

Migrate Danger to use danger-pr-comment workflow #581

dblock merged 1 commit into from
Dec 30, 2025
+32 −28

Conversation

@dblock
Copy link
Collaborator

@dblock dblock commented Dec 30, 2025

Summary

  • Migrates Danger to use the reusable danger-pr-comment workflow from numbata/danger-pr-comment
  • Replaces manual Danger setup with cleaner reusable workflows
  • Adds danger-pr-comment gem dependency

Changes

  • Added .github/workflows/danger.yml - Main Danger workflow using reusable workflow
  • Added .github/workflows/danger-comment.yml - Workflow to post PR comments
  • Removed .github/workflows/pr_lint.yml - Replaced by new workflows
  • Updated Dangerfile to import danger-pr-comment gem
  • Updated Gemfile.danger to include danger-pr-comment dependency

Test plan

  • Verify Danger workflow runs successfully on this PR
  • Verify changelog check still works
  • Verify TOC check still works

🤖 Generated with Claude Code

@dblock dblock force-pushed the migrate-danger-pr-comment branch 2 times, most recently from 8276aac to b0cd0bd Compare December 30, 2025 18:09
@coveralls
Copy link

coveralls commented Dec 30, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20603082341

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 90.999%
Totals Coverage Status
Change from base Build 20255532104: 0.04%
Covered Lines: 5055
Relevant Lines: 5555
💛 - Coveralls

@dblock dblock force-pushed the migrate-danger-pr-comment branch 2 times, most recently from fe2cab9 to f3365b8 Compare December 30, 2025 18:18
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
71e21c6 
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@dblock dblock force-pushed the migrate-danger-pr-comment branch from f3365b8 to 71e21c6 Compare December 30, 2025 18:19
@dblock dblock merged commit 4e2880f into slack-ruby:master Dec 30, 2025
11 checks passed
@dblock dblock deleted the migrate-danger-pr-comment branch December 30, 2025 18:24
@dblock dblock mentioned this pull request Dec 30, 2025
Merged
3 tasks
dblock added a commit to dblock/slack-ruby-bot-server-events-app-mentions that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
c827ac9 
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@dblock dblock mentioned this pull request Dec 30, 2025
Merged
dblock added a commit to dblock/slack-ruby-bot-server-events-app-mentions that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
2acc3bf 
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/slack-ruby-bot-server-events-app-mentions that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
96917cc 
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/slack-ruby-bot-server-events-app-mentions that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
ed3d79a 
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/slack-ruby-bot-server-events-app-mentions that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
4c48660 
Updated to use the numbata/danger-pr-comment reusable workflow pattern,
replacing manual Danger setup with cleaner workflow delegation. This brings
the implementation in line with slack-ruby/slack-ruby-client#581 and
slack-ruby/slack-ruby-bot-server#181.

Changes:
- Updated danger.yml to use danger-run.yml reusable workflow
- Added danger-comment.yml workflow for posting PR comments
- Updated Dangerfile to import danger-pr-comment gem and use changelog.check! and toc.check!
- Added danger-pr-comment gem to Gemfile.danger
- Updated Ruby version from 2.7 to 3.4

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger-entity that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
a9e01f7 
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment gem
- Add changelog.check! and toc.check! to Dangerfile
- Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@dblock dblock mentioned this pull request Dec 30, 2025
Merged
dblock added a commit to dblock/grape-swagger-entity that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
f17613e 
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment gem
- Add changelog.check! and toc.check! to Dangerfile
- Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This was referenced Dec 30, 2025
Open
Merged
Merged
dblock added a commit to dblock/grape-swagger that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
54480d5 
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181.

- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check!
- Replace danger.yml workflow with reusable workflow pattern
- Add danger-comment.yml workflow for PR comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@dblock dblock mentioned this pull request Dec 30, 2025
Open
4 tasks
dblock added a commit to dblock/grape-swagger that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
00b9cd9 
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181.

- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check!
- Replace danger.yml workflow with reusable workflow pattern
- Add danger-comment.yml workflow for PR comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger-entity that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
2b20f59 
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment gem
- Add changelog.check! and toc.check! to Dangerfile
- Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
8d9ed57 
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181.

- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check!
- Replace danger.yml workflow with reusable workflow pattern
- Add danger-comment.yml workflow for PR comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
e36f5b8 
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181.

- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check!
- Replace danger.yml workflow with reusable workflow pattern
- Add danger-comment.yml workflow for PR comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
07a05ab 
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181.

- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check!
- Replace danger.yml workflow with reusable workflow pattern
- Add danger-comment.yml workflow for PR comments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock added a commit to dblock/grape-swagger-entity that referenced this pull request Dec 30, 2025
@dblock @claude
Migrate Danger to use danger-pr-comment workflow.
6583ad7 
- Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile
- Update Dangerfile to import danger-pr-comment gem
- Add changelog.check! and toc.check! to Dangerfile
- Follows pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dblock @coveralls