Accumulate :refers from multiple :require-macros #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkdude
reviewed
Dec 23, 2025
willcohen
force-pushed
the
multiple-macros
branch
from
d00004f to
5aaf753
Compare
willcohen
force-pushed
the
multiple-macros
branch
from
5aaf753 to
f07106d
Compare
Member
|
Would you mind fixing this for squint too? It likely has the same problem |
Contributor
Author
|
Can’t do today but happy to tomorrow! |
3 tasks
Contributor
Author
|
PR at squint-cljs/squint#780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer the following questions and leave the below in as part of your PR.
This PR corresponds to an issue with a clear problem statement.
:require-macros overwrite instead of accumulate #182
This PR contains a test to prevent against future regressions
Added to test_project, so that it reflects the node path. I couldn't reproduce with compiler test.
I have updated the CHANGELOG.md file with a description of the addressed issue.