Accumulate :refers from multiple :require-macros #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
|
Thanks. Probably the test that captures the test output should also be updated? |
willcohen
force-pushed
the
multiple-macros
branch
from
b98d014 to
eaaa5f8
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re squint-cljs/cherry#183 (comment), easier than I thought given the existing macro tests in the test-project.
This PR corresponds to an issue with a clear problem statement.
:require-macros overwrite instead of accumulate cherry#182
This PR contains a test to prevent against future regressions
I have updated the CHANGELOG.md file with a description of the addressed issue.