Skip to content

Conversation

@theGiallo
Copy link
Owner

Fix dead link issue vispy#2044

@kmuehlbauer
Copy link

@theGiallo Thanks for taking care of this. To actually advertise these changes to "vispy" repository you would need to point the PullRequest to https://github.com/vispy/vispy not your fork. Same applies to the other PullRequest. Thanks again!

I tried to switch the base but was not successful. If you encounter problems when trying to switch you also might just open the PR newly at: https://github.com/vispy/vispy/compare, select `compare across forks" and then chosse your fork/branch.

If this doesn't work, let me know. I'll then fetch your commit(s) and create a PR from my side keeping your authoring intact.

@theGiallo
Copy link
Owner Author

Oh, yes. I don't really know what this PR I did is for. I did it from a smartphone :D I just did another across forks vispy#2050

Thank you for the time you took to explain.

@kmuehlbauer
Copy link

No worries, you are welcome. The PR's look good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants