-
Notifications
You must be signed in to change notification settings - Fork 9
Add Azure integration test backend #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Azure integration test backend #170
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This commit updates the test utils to support running trusted execution cluster tests on the OpenShift platform. To execute these tests on OpenShift, the following environment variables must be configured: - REGISTRY: The repository location of the container image. - TAG: The specific tag of the container image. - CLUSTER_URL: The API URL of the target cluster. - PLATFORM: Set this to 'openshift'. Signed-off-by: Roy Kaufman <rkaufman@redhat.com>
Split test_utils::virt into a module with separate virt::kubevirt. Signed-off-by: Jakob Naucke <jnaucke@redhat.com> Assisted-by: Claude
| } | ||
|
|
||
| async fn create_machine(client: Client, uuid: &str, client_ip: &str) -> anyhow::Result<()> { | ||
| let machines: Api<Machine> = Api::default_namespaced(client); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we open a separate PR for this?
|
|
||
| integration-tests: generate trusted-cluster-gen crds-rs | ||
| RUST_LOG=info REGISTRY=$(REGISTRY) TAG=$(TAG) \ | ||
| TRUSTEE_IMAGE=$(TRUSTEE_IMAGE) APPROVED_IMAGE=$(APPROVED_IMAGE) TEST_IMAGE=$(TEST_IMAGE) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you also update the README for the integrations tests
Less double-tracking and adds flexibility for testing on cloud
platforms.
Environment variables:
- {TEST,TRUSTEE,APPROVED}_IMAGE
- TEST_NAMESPACE_PREFIX
Other changes:
- OpenShift service exposure
- Remove CLUSTER_URL, get it from OpenShift directly
- Reduce some lines & indentation in
TestContext::apply_operator_manifests and break it up some
- Move endpoint constants to lib
- Log error upon poll timeout
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Signed-off-by: Jakob Naucke <jnaucke@redhat.com> Co-authored-by: Uri Lublin <uril@redhat.com> Assisted-by: Gemini, Claude
a72a201 to
fece91b
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.