Improve pre-pull script with error handling and summary reporting #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yalzhang The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Refactor scripts/pre-pull-images.sh to handle failures gracefully: - Skip empty image references (unset env vars) - Suppress verbose docker pull output for cleaner logs - Continue on pull failures instead of stopping - Remove kind load calls (K8s uses Docker cache directly) - Use APPROVED_IMAGE env var instead of hardcoded image This allows the script to continue even if some images fail to pull, since Kubernetes will pull them on-demand during pod creation. Signed-off-by: Yalan Zhang <yalzhang@redhat.com>
yalzhang
force-pushed
the
fix_pre_image_pull
branch
from
600a112 to
6faa736
Compare
|
@yalzhang: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add failure tracking, pull summary, and best-effort execution to scripts/pre-pull-images.sh. Use APPROVED_IMAGE env var for flexibility. Removed kind load docker-image calls since K8s can use Docker cache directly.