Skip to content

Improve pre-pull script with error handling and summary reporting #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yalzhang wants to merge 1 commit into from
Closed

Improve pre-pull script with error handling and summary reporting #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions scripts/pre-pull-images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
#
# SPDX-License-Identifier: CC0-1.0

set -o pipefail

KV_VERSION=v1.7.0
IMAGES=(
"quay.io/kubevirt/virt-launcher:${KV_VERSION}"
Expand All @@ -12,17 +14,31 @@ IMAGES=(
"quay.io/kubevirt/virt-controller:${KV_VERSION}"
"quay.io/kubevirt/virt-operator:${KV_VERSION}"
"$TRUSTEE_IMAGE"
"quay.io/trusted-execution-clusters/fedora-coreos-kubevirt:2026-14-01"
"$APPROVED_IMAGE"
)

echo "=========================================="
echo "Pre-pulling images to Docker daemon"
echo "=========================================="
echo "Note: Failures are non-fatal - K8s will pull on-demand"
echo ""

for IMAGE in "${IMAGES[@]}"; do
echo "Pulling: $IMAGE"
docker pull "$IMAGE"
if [ $? -eq 0 ]; then
echo "Successfully pulled $IMAGE"
else
echo "Error: Failed to pull $IMAGE"
fi
kind load docker-image $IMAGE
echo "-------------------------------"
# Skip empty image names
if [ -z "$IMAGE" ]; then
echo "[WARN] Skipping empty image reference"
continue
fi

echo "Pulling: $IMAGE"

if docker pull "$IMAGE" >/dev/null 2>&1; then
echo "[SUCCESS] Pulled: $IMAGE"
else
echo "[WARN] Failed to pull: $IMAGE (will retry during pod creation)"
fi

echo "-------------------------------"
done

exit 0