Skip to content

Update to latest version of SwiftLint #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kelan merged 426 commits into from
Feb 14, 2025
Merged

Update to latest version of SwiftLint #6

kelan merged 426 commits into from
Feb 14, 2025

Conversation

@kelan
Copy link
Collaborator

@kelan kelan commented Feb 14, 2025

Pull in the latest from the origin repo

SimplyDanny and others added 30 commits August 22, 2024 13:20
@SimplyDanny
Release 0.56.2
a24488f
@SimplyDanny
Add new changelog section
fb8551f
@SimplyDanny
Add fixed releaser
7d539ac 
It should actually work without this config as long as the releaser is
not a bot. However, the BCR publishing step wasn't triggered. So perhaps
this config is required ... We'll see in the next round.
@dependabot
Bump rexml from 3.3.3 to 3.3.6 (#5767)
1331508 
Bumps the bundler group with 1 update in the / directory: [rexml](https://github.com/ruby/rexml).


Updates `rexml` from 3.3.3 to 3.3.6
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.3.3...v3.3.6)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: indirect
  dependency-group: bundler
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ikelax
Swift type checking using is (#5561)
9f4cb92
@mildm8nnered
Remove anyobject_protocol rule (#5770)
60a1d34
@leonardosrodrigues0 @SimplyDanny
Add options to opening_brace rule that silence it on multiline stat…
3bb8014 
…ements and types (#5521)

Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
@samrayner
Reverse Data -> String conversion rule (#5601)
48aaca6
@SimplyDanny
Update Bazel pre-submit steps
dfd19bd 
This is the version of the file that was used to add 0.56.2 to BCR.
@huixuhx
Add instructions for installation in Chinese (#5777)
94d4f7a
@aryamansharda @SimplyDanny
Add new attribute_name_spacing rule (#5669)
ae3f0c4 
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
@enricenrich
Use Diagnostics.error when command failed (#5782)
27cab44
@SimplyDanny
Remove empty lines
e845163
@SimplyDanny
Auto-upload Linux build
d601c22
@SimplyDanny
Update release instructions
d136b02
@SimplyDanny
Move release instructions
1dbe095
@mildm8nnered @SimplyDanny
Fix superfluous_disable_command for custom_rules (#5670)
06e4e3c 
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
@mildm8nnered
Preserve trailing comments for opening_brace rule (#5780)
9e78054
@mildm8nnered
no_magic_numbers rule now ignores violations in Preview macros (#5778)
8baec9e
@SimplyDanny
Combine release jobs into one workflow
7afe2dc
@SimplyDanny
Get tag name from release object
1db3efd
@SimplyDanny
Automate Pod publishing
551adb0
@SimplyDanny
Release 0.57.0
168fb98
@SimplyDanny
Add new changelog section
0654797
@SimplyDanny
Fix workflow syntax
9da392d
@SimplyDanny
Allow to trigger Docker build manually
614e694
@SimplyDanny
Read tag from workflow input
274d12b
@SimplyDanny
Ensure expected initializer signature (#5786)
85c4dbe
@SimplyDanny
Run command plugin in whole package if no targets defined (#5789)
8241909
@chipp
Do not throw deprecation warning if property is not present in config…
0d04196 
…uration (#5792)
SimplyDanny and others added 21 commits January 23, 2025 18:05
@SimplyDanny
Move more build steps into Makefile (#5975)
6cf862c
@OneSadCookie
Parallelize SwiftLintFile construction for a modest speedup (#5967)
010028a
@OneSadCookie @SimplyDanny
Avoid reading files before checking the cache (#5973)
0460a6c 
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
@SimplyDanny
Consider composed inherited types (#5984)
6ba231a
@SimplyDanny
Verify that severity can be configured per rule (#5985)
a4893f6
@OneSadCookie
Parallelize file grouping (#5983)
4eb19be
@SimplyDanny
Automatically merge release branch upon publishing a release
f4ccdc4
@SimplyDanny
Add job to lint workflow files (#5989)
2ba03c1
@SimplyDanny
Update Docker image used in testing
b2312b5
@SimplyDanny
Fix linting issues in README (#5991)
2686268
@SimplyDanny
Update contribution manual (#5992)
b0e4fc5
@SimplyDanny
Fix some typos (#5993)
23de382
@SimplyDanny
Enable upcoming features improving concurrency checking (#5994)
849dbfd 
* `InferSendableFromCaptures`
* `GlobalActorIsolatedTypesUsability`
@SimplyDanny
Ensure that content is complete using an awaitable stream (#5986)
82fd3e4
@SimplyDanny
Delete branch after merge
a2032f9
@SimplyDanny
Restrict workflow permissions (#5996)
2cdb868
@SimplyDanny
Restrict permissions of remaining workflows (#5997)
b1198b7
@SimplyDanny
Move --only-rule option to common arguments (#5981)
364442a
@SimplyDanny
Exclude @Suite types and @Test functions from no_magic_numbers …
6c8e899 
…analysis (#5968)
@SimplyDanny
Add new opaque_over_existential rule (#5915)
82736d1
@kelan
Merge remote-tracking branch 'origin/main' into kc/latest
732778c 
* origin/main: (424 commits)
  Add new `opaque_over_existential` rule (#5915)
  Exclude `@Suite` types and `@Test` functions from `no_magic_numbers` analysis (#5968)
  Move `--only-rule` option to common arguments (#5981)
  Restrict permissions of remaining workflows (#5997)
  Restrict workflow permissions (#5996)
  Delete branch after merge
  Ensure that content is complete using an awaitable stream (#5986)
  Enable upcoming features improving concurrency checking (#5994)
  Fix some typos (#5993)
  Update contribution manual (#5992)
  Fix linting issues in README (#5991)
  Update Docker image used in testing
  Add job to lint workflow files (#5989)
  Automatically merge release branch upon publishing a release
  Parallelize file grouping (#5983)
  Verify that severity can be configured per rule (#5985)
  Consider composed inherited types (#5984)
  Avoid reading files before checking the cache (#5973)
  Parallelize SwiftLintFile construction for a modest speedup (#5967)
  Move more build steps into Makefile (#5975)
  ...
@kelan kelan requested a review from Killectro February 14, 2025 21:10
@kelan
Fix the --strict lint warnings in our code
15c4f45 
Failed CI run: https://github.com/Whatnot-Inc/SwiftLint/actions/runs/13337551312/job/37255970465?pr=6

Errors:
```
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/TextConcatenationRule.swift:54:62: error: Opaque Over Existential Parameter Violation: Prefer opaque over existential type in function _existential)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/TextConcatenationRule.swift:23:17: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/TextConcatenationRule.swift:38:14: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/JSONDecodingRule.swift:30:17: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/JSONDecodingRule.swift:42:17: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/NavigationTitleRule.swift:27:17: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/NavigationTitleRule.swift:44:17: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/LocaleOverrideRule.swift:15:52: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/LocaleOverrideRule.swift:29:17: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/TextLocalizationRule.swift:22:17: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/TextLocalizationRule.swift:35:50: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/StringLocalizationCorrectArgumentsRule.swift:34:17: error: Trailing Comma Violation: Multi-line collection literals should have trailing )
SwiftLint/Source/SwiftLintBuiltInRules/Rules/Whatnot/StringLocalizationCorrectArgumentsRule.swift:92:17: error: Trailing Comma Violation: Multi-line collection literals should have trailing commas (trailing_comma)
```
@kelan kelan merged this pull request into main Feb 14, 2025
3 checks passed
@kelan kelan deleted the kc/latest branch February 14, 2025 22:20
@kelan kelan mentioned this pull request Feb 14, 2025
Closed
@kelan kelan mentioned this pull request Feb 25, 2025
Merged
@kelan
Copy link
Collaborator Author

kelan commented Feb 25, 2025

For the record, I force-pushed main back a commit, to undo this, because it landed as a squash merge, which messes up history. I re-applied it (with a normal merge commit) in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Killectro Killectro Killectro approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.