-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Test Bazel 9.0.0 #28294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Bazel 9.0.0 #28294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Bazel version to 9.0.0rc5 and regenerates the MODULE.bazel.lock file. The changes, including the updated lockFileVersion and the new format for module extensions within the lock file, are consistent with the Bazel version upgrade. The changes appear correct for the stated purpose of testing the new Bazel release candidate.
|
I'm seeing a lot for errors like: |
|
RBE failed with /cc @coeuvre Do we need to upgrade the config again? |
|
@meteorcloudy Turns out the remote repo contents cache is always used for writes, even if not enabled. I'll send a fix for that and also to avoid the warning spam. |
|
@fmeum Awesome, thanks! @iancha1992 @Wyverald Looks like we'll need another quick rc. |
* The cache was always written to, even if not enabled. * Google RBE doesn't accept `Command`s without the (deprecated) `Platform` field set. We set it both on `Command` and `Action`, just to be safe. Fixes bazelbuild#28294 (comment) Closes bazelbuild#28295. PiperOrigin-RevId: 856169835 Change-Id: I2479119a173e325a7d39643a36536569f5f831fc
* The cache was always written to, even if not enabled. * Google RBE doesn't accept `Command`s without the (deprecated) `Platform` field set. We set it both on `Command` and `Action`, just to be safe. Fixes #28294 (comment) Closes #28295. PiperOrigin-RevId: 856169835 Change-Id: I2479119a173e325a7d39643a36536569f5f831fc Commit a994609 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
220ec1c to
ae0bfb4
Compare
ae0bfb4 to
02fd688
Compare
Testing Bazel 9.0.0rc5 by updating .bazelversion and MODULE.bazel.lock.