Skip to content

Conversation

@meteorcloudy
Copy link
Member

Testing Bazel 9.0.0rc5 by updating .bazelversion and MODULE.bazel.lock.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 14, 2026
@meteorcloudy meteorcloudy marked this pull request as draft January 14, 2026 10:28
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Bazel version to 9.0.0rc5 and regenerates the MODULE.bazel.lock file. The changes, including the updated lockFileVersion and the new format for module extensions within the lock file, are consistent with the Bazel version upgrade. The changes appear correct for the stated purpose of testing the new Bazel release candidate.

@meteorcloudy
Copy link
Member Author

I'm seeing a lot for errors like:


(10:30:07) WARNING: Failed to upload repo contents to remote cache for repo @@bazel_skylib+: java.io.IOException: io.grpc.StatusRuntimeException: FAILED_PRECONDITION: Command.Platform not set
--
at com.google.devtools.build.lib.remote.GrpcCacheClient.lambda$uploadActionResult$3(GrpcCacheClient.java:316)
at com.google.common.util.concurrent.AbstractCatchingFuture$AsyncCatchingFuture.doFallback(AbstractCatchingFuture.java:207)
at com.google.common.util.concurrent.AbstractCatchingFuture$AsyncCatchingFuture.doFallback(AbstractCatchingFuture.java:194)
at com.google.common.util.concurrent.AbstractCatchingFuture.run(AbstractCatchingFuture.java:136)
at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30)
at com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1004)
at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:767)


@fmeum @Wyverald

@meteorcloudy
Copy link
Member Author

RBE failed with


(10:30:14) ERROR: error loading package '@@+rbe_preconfig+rbe_ubuntu2004//cc': initialization of module 'cc/cc_toolchain_config.bzl' failed
--
(10:30:14) ERROR: /workdir/src/test/java/com/google/devtools/build/lib/remote/zstd/BUILD:37:16: Target '//src/test/java/com/google/devtools/build/lib/remote/zstd:zstd_benchmark_/zstd_benchmark' depends on toolchain '@@+rbe_preconfig+rbe_ubuntu2004//cc:cc-compiler-k8', which cannot be found: error loading package '@@+rbe_preconfig+rbe_ubuntu2004//cc': initialization of module 'cc/cc_toolchain_config.bzl' failed'
(10:30:14) ERROR: Analysis of target '//src/test/java/com/google/devtools/build/lib/remote/zstd:zstd_benchmark' failed; build aborted: Analysis failed

/cc @coeuvre Do we need to upgrade the config again?

@fmeum
Copy link
Collaborator

fmeum commented Jan 14, 2026

@meteorcloudy Turns out the remote repo contents cache is always used for writes, even if not enabled. I'll send a fix for that and also to avoid the warning spam.

@meteorcloudy
Copy link
Member Author

@fmeum Awesome, thanks!

@iancha1992 @Wyverald Looks like we'll need another quick rc.

@fmeum
Copy link
Collaborator

fmeum commented Jan 14, 2026

#28295

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jan 14, 2026
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 14, 2026
* The cache was always written to, even if not enabled.
* Google RBE doesn't accept `Command`s without the (deprecated) `Platform` field set. We set it both on `Command` and `Action`, just to be safe.

Fixes bazelbuild#28294 (comment)

Closes bazelbuild#28295.

PiperOrigin-RevId: 856169835
Change-Id: I2479119a173e325a7d39643a36536569f5f831fc
@meteorcloudy meteorcloudy reopened this Jan 14, 2026
meteorcloudy pushed a commit that referenced this pull request Jan 14, 2026
* The cache was always written to, even if not enabled.
* Google RBE doesn't accept `Command`s without the (deprecated)
`Platform` field set. We set it both on `Command` and `Action`, just to
be safe.

Fixes
#28294 (comment)

Closes #28295.

PiperOrigin-RevId: 856169835
Change-Id: I2479119a173e325a7d39643a36536569f5f831fc

Commit
a994609

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@meteorcloudy meteorcloudy force-pushed the test-bazel-9.0.0rc5 branch 2 times, most recently from 220ec1c to ae0bfb4 Compare January 16, 2026 08:55
@meteorcloudy meteorcloudy changed the title Test Bazel 9.0.0rc5 Test Bazel 9.0.0 Jan 16, 2026
copybara-service bot pushed a commit that referenced this pull request Jan 16, 2026
- Pass --test_env=PATH to tests
- Make sure MSYS bin dir is respected for tools like `find`.

Related #28294

Fixes #28297
Fixes #28233

PiperOrigin-RevId: 857016089
Change-Id: I7b5d206ff63554631d3c64a42f9225a51c55752f
Wyverald pushed a commit that referenced this pull request Jan 21, 2026
- Pass --test_env=PATH to tests
- Make sure MSYS bin dir is respected for tools like `find`.

Related #28294

Fixes #28297
Fixes #28233

PiperOrigin-RevId: 857016089
Change-Id: I7b5d206ff63554631d3c64a42f9225a51c55752f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants